feat(review): the pin follows the lock - #249
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cases.current_edition_idis gone withAdvanceCurrentEditionandReleaseToLatestEdition, and intake stops skippingto-reviewcases (the dd9c192d95e0 freeze: evidence hidden to protect a reviewer who did not exist)displayedEdition(lock → latest) feedsfactsOf, the grid'sresolveEdition, comment anchors, reference stamps, coverage restoresdeliverre-stamps the live lock onto the latest — nothing to do when nobody holdsacceptedblind to an edition already waitingfresh(on-load — re-stamps onto the latest) or a heartbeat (keeps the bytes). Reloading is leaving and coming back; without the distinction a reload raced its own keepalive release and showed one edition or the other by timing. In the ADR, in the contract (POST lock {fresh}), in the clientcase_locks.edition_id, drop of the stored pin), exercised Up→Down→UpTest plan
TestAFreeCaseReadsAtTheLatestEdition(the dd9c192d95e0 shape — a video landed after birth shows),TestAHeldCaseKeepsItsBytesUntilTheLockDies(held bytes stable through a push, latest after expiry, no write in between)TestADeliveryAdvancesTheCaseOntoItsEditiongreen through the re-stamp, untouchedgrep -rn current_edition_id apps/server/answers only the migrationsExisting tests reworked (the issue pre-approved the list; two more surfaced):
TestAnIntakeDoesNotMoveTheBytesUnderAReviewer— now holds the lock, as the guarantee requiresTestACaseCatchesUpOnceItsReviewEnds→TestACaseCatchesUpAsSoonAsNobodyHoldsItTestAnOlderEditionDoesNotDrawAStepBornLaterneeded nothing: it pins through the explicit edition parameter, which survivesTestAnOlderEditionCanStillBeRead's second half carried the status premise (default read frozen) — it now asserts the free case reads the latest;TestACommentAnchorsToTheCaptureItWasWrittenAbout's fixture passes the anchor editionAttachCommentVariantnow requiresCloses #248