feat(android): add note history screen with preview and restore - #193
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings note history (#183) to Android.
history/note_at/restore_version+ aNoteVersionInforecord, wrappingclient::commands.history/noteAt/restoreVersiononNoteRepository; ViewModelopenHistory/previewVersion/restoreVersion/closeHistory/closePreviewwithhistoryandversionPreviewstate.HistorySheetopened from the editor — a timeline (newest first,Actuelchip on the current, chevrons on the rest), a read-only version preview, and Restore (which refreshes the open editor). Time-only labels in v1 per the validated mockup.Test plan
./gradlew :app:verifyRoborazziDebug(local, JDK 17): unit tests + goldens greenHistoryScreenshotTest— timeline golden, light + dark (timezone pinned to UTC for determinism)history_preview_and_restore(open → preview → restore, via a fake repo)cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test -p plain-note-mobileNote: the Roborazzi golden covers the read-only timeline; the interactive preview/restore states are covered by the ViewModel test. Emulator screencaps of the interactive states weren't captured (no emulator in this environment) — the mockup (validated) shows those states.
Part of #179
Closes #192