chore(deps): replace rand with getrandom for OS entropy - #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #8. Dependabot's
rand0.8→0.10 bump revealed that rand 0.10 removedOsRngfrom the crate (andrand_core) entirely. Our only use ofrandwasOsRng.fill_bytes(&mut buf)(nonces, keys, ids, challenges), so rather than chase rand's churn, drop the directranddependency and usegetrandom::fill— the OS CSPRNG thatOsRngmerely wrapped.rand = "0.8"→getrandom = "0.4";rand.workspace→getrandom.workspacein core/relay/client.OsRng.fill_bytes(&mut x)→getrandom::fill(&mut x).expect("OS RNG unavailable")in src and tests. No directrandleft (randremains only as a transitive dep of ed25519-dalek etc.).Test plan
cargo test --workspace— all suites green (crypto/model/relay/e2e still pass with getrandom)cargo clippy --workspace --all-targets -- -D warnings,cargo fmt --all --checkCloses #8