chore(changelog): move the unless entry to the version that ships it - #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
unlessremoval (#619) was documented under## [0.12.0]— a version tagged and published before that work existed. The changelog therefore claimed a fix shipped in a release that does not contain it.My mistake, and a mechanical one: the script that inserted the entry replaced the first
### Changedin the file, which belonged to the released section because[Unreleased]had none yet.A second consequence, worth naming
test/changelog-rule.shonly checks[Unreleased], so the entry was never measured against the word ceiling. Moved into place it came out at 62 words, over the 60 limit — it has been shortened, which is the only wording change here.Why a separate PR rather than folding this into the release roll
The correction concerns v0.12.0, already published; the roll concerns the version being prepared. And
/releasesays in as many words not to edit entries during the roll — so the fix lands before it, not inside it.Test plan
[0.12.0]section, and appears once under[Unreleased] / Changed.test/changelog-rule.shgreen — which is now meaningful for this entry for the first time.Fixedlines added since the release were already in the right place, checked one by one.