fix(lang): refuse a def call missing a required argument - #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file.write(path)inside a def therefore overwrote the file with nothing and reportedok.done.internal/lang/eval.gochecked only the upper bound. A plan-level call has always been checked on both (parser.go), so the same mistake was refused in a plan and silent in a def — where defs compose and nobody reads the call site.What the audit established before any code
requiredCount(parser.go:276) already counts parameters without a default, in the same package. The lower bound is that count, so omitting a defaulted parameter stays legal — which is what defaults are for.docker.prune,docker.compose-restart,dir.copy,dir.sync) are unaffected.Test plan
go test ./...,lint.sh,dead-code.sh,coverage-ratchet.sh,changelog-rule.sh— green.Out of scope
Why a def-side call and a plan-side call are validated by two separate pieces of code at all. That is worth an issue; it is not this fix.
Closes #633