fix(std): observe everything htpasswd.entry and system.timezone apply - #644
Merged
Conversation
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
htpasswd.entrynow observes the mode its apply sets. A file whose stored hash alreadyverified was reported
alreadyat 644, and thechmod 600never ran — a credentials fileleft world-readable, under the def's own comment saying what that costs.
system.timezonenow observes/etc/timezoneas well as the symlink. A host with theright link and another zone in that file converged, and the file stayed wrong.
The shape proposed in #636 —
recorded: <file contents>— would not have convergedcorrectly: a field with no same-named parameter only has to be truthy
(
internal/lang/eval.go:471-483), so any zone would pass. It is a comparison instead.Test plan
Two adverse cases of the third kind (
test/e2e/adverse-cases.md), each verified red on areal container before the fix:
and green after, with convergence and the machine checked:
Local gates:
go test ./...,test/lint.sh,test/dead-code.sh,test/coverage-ratchet.sh(81.8%),test/changelog-rule.sh,test/e2e/def-coverage.sh.Also here
adverse-cases.mdgains the rule this pair taught: a third-kind case must build a state thedef would call converged, or the apply runs for another reason and the assertion cannot
fail. Both defects already had an assertion beside them that passed for exactly that reason.
Its stale counts (8 cases / 38 defs) are corrected to 28 / 49 in passing.
Closes #635
Closes #636