fix(std): pass the tar member name after -- - #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archive.extract-memberpassed"$member"totarwith no--, on both the observe(
archive.shellf:62) and the apply (:78). A member named-rf.txtis read as options, sothe observe saw a hash mismatch and the apply failed — for ever, since neither run can
converge. The name comes from whoever built the archive, not from the plan.
The two other
tarcalls in the file take no member (tar xzf … -C,tar tzf) and areunaffected — checked, not assumed.
Test plan
test/e2e/plans/adverse-archive.extract-member-dash.shellf, verified red on a real containerbefore the fix:
The four existing archive cases re-run green beside it (
extract-member,extract,extract-contents,extract-emptied).Its own file rather than an extension of
adverse-archive.extract-member.shellf: one plan percase (
adverse-cases.md), and that plan already carries the space/quote/&argument. Thefixture needs no
--transform—tar czf … -C src -- -rf.txtstores the bare name, whichtar czf … .never produces, which is exactly why this is reachable and rare.go test ./...,test/changelog-rule.sh,test/e2e/def-coverage.shgreen.Closes #639