Repository navigation
refactor: behavior-preserving hygiene - #3
Merged
Merged
Conversation
added 5 commits
October 6, 2026 13:40
Deduplicate security-scoped bookmark create/resolve paths and SpaceConfig copies. Assign still keys configs by spaceKey; unused fallbackURL is dropped from resolveBookmark.
Remove dead GlassEffectType/button helpers, unused About compact/legacy layout, unused brand gradients, unused hover state, and duplicate AppMetrics calls already performed by ConfigStore.assign.
Keep the same assertions with less setup, folding static-mode appearance coverage into DynamicWallpaperTests.
Share a single LivelyCategoryLogger path, seed UserDefaults defaults once, drop unused frameRateCap alias and power-source helper, and skip a redundant WallpaperWindow setFrame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared bookmark helpers and logger. Offline per-Space wallpaper, bookmark permission flags, and file paths are unchanged. CI build-and-test green.
Known deviations:
assignalready records wallpaper-applied metrics; a second call on the same path was removed. Same-dayrecordWallpaperAppliedis a no-op.Draft; do not merge until reviewed.