Repository navigation
refactor: hygiene — dead helpers and shared quote/settings paths - #9
Merged
Merged
Conversation
added 5 commits
October 6, 2026 13:35
Remove the unused day-start helper and unused metrics writer, export the content-lifecycle stage set once, and reuse one header lookup plus one TTL cache path for Yahoo/Finnhub fetches.
Resolve crypto tape ids through the shared catalog, schedule the price alarm from one helper, and write poll state through a single persist path after quota pruning.
Drop unused tape/options helpers, share drop-zone and save wiring, and reuse popup tab plus P&L display helpers without changing user-visible copy or P&L math.
buildCryptoTickerItems used the wide catalog resolver, which accepted names and usd suffixes the old table rejected. Restore normalizeCryptoId for tickers. Holdings still use resolveCryptoCatalogEntry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared quote cache and settings helpers. MV3 permissions, pts_* keys, quote URLs/timeouts, and P&L math are unchanged.
Ticker symbols go through the original
CRYPTO_ID_BY_SYMBOLtable (normalizeCryptoId). Holdings still use the widerresolveCryptoCatalogEntry. Inputs the old ticker path left unknown (BTCUSD,bitcoinusd,Bitcoin) stay unknown on the ticker path. Localnpm test91 pass. CI test 20.x / 22.x green.Draft; do not merge until reviewed.