Skip to content

fix: close audit findings — UI polish, security, CI - #3

Merged
harshabala merged 1 commit into
masterfrom
fix/audit-remediation
Jul 1, 2026
Merged

harshabala merged 1 commit into
masterfrom
fix/audit-remediation

Conversation

@harshabala

Copy link
Copy Markdown
Owner

Summary

Closes all findings from the four-skill audit (frontend-design-guidelines, userinterface-wiki, design-motion-principles, review-and-iterate).

UI / accessibility

  • Visible focus rings on icon buttons and checkboxes
  • FormatSelector ARIA parity with ThemeSelector
  • Settings tabs: aria-controls, panel crossfade transitions
  • panelBlurFlyIn on main/settings/history panels; motion gaps on banners, hotkey errors, Recent, HUD
  • Design token cleanup (--status-error), hit target sizing

Security / production

  • Remove unused copy_file_to_clipboard IPC
  • Harden save_error_report against path traversal
  • scan_directory depth/file limits; token_stats.events capped at 500
  • E2E auto-update hook gated to debug builds

Infra / docs

  • GitHub Actions CI: npm test, svelte-check, cargo test
  • PRODUCT.md / brand.md aligned with signing and typography reality

Tests

  • 47 frontend tests passing
  • 36 Rust tests passing (incl. new security + events cap tests)
  • svelte-check clean

UI/accessibility:
- Icon button focus rings, larger header hit targets, checkbox focus
- FormatSelector ARIA parity, settings tab panels with aria-controls
- panelBlurFlyIn on view transitions, tab/hotkey/banner motion gaps
- Token/error CSS tokens (--status-error), tighter section labels

Security:
- Remove unused copy_file_to_clipboard IPC command
- Sanitize save_error_report filenames and confine to output dir
- Cap scan_directory depth/files; cap token_stats events at 500
- Gate PARSEKIT_E2E_INSTALL_UPDATE to debug builds only

Infra/docs:
- Add GitHub Actions CI (npm test, svelte-check, cargo test)
- Align PRODUCT.md and brand.md with actual signing/typography
@harshabala
harshabala merged commit 63d906c into master Jul 1, 2026
0 of 2 checks passed
@harshabala
harshabala deleted the fix/audit-remediation branch July 1, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant