Repository navigation
feat(drive): Disconnect Google Drive + connection state; fix store-ID OAuth docs - #11
Merged
Merged
Conversation
… Settings - Background: DISCONNECT_GOOGLE_DRIVE revokes the live access token with Google (best effort) and always clears the stored token and account email; GET_DRIVE_STATUS reports whether this device is connected. - Settings: shows "Connected as ..." on load, Reconnect/Disconnect buttons, and hides the developer-only OAuth redirect hint (still in Diagnostics and in connect error messages). - Fix: connect handler read the email from the response wrapper instead of res.data, so "Connected as ..." never appeared. - Privacy policy (md + html) now documents disconnect; last updated September 27, 2026; releaseDocs test guards it. - Store docs: MANIFEST_NOTES no longer says the key must stay (the store package strips it); owner checklist and Drive setup now say to register the store item's redirect URI after first upload. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHFhkzNyPBLTv6hU2PeX3e
The store listing, permissions doc, privacy policy, README and code of conduct listed harsha16balakrishnan@proton.me. releaseDocs test now guards the privacy policy against the old address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHFhkzNyPBLTv6hU2PeX3e
harshabala
marked this pull request as ready for review
September 27, 2026 07:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last open code-side item from the v0.3.0 release checklist ("in-app disconnect Google Drive button"). It also fixes store docs that went stale once the package started stripping
key.Changes
DISCONNECT_GOOGLE_DRIVEmessage revokes the live access token atoauth2.googleapis.com/revoke(best effort) and always deletes the stored token and account email. The backup file in Drive appData is left in place.GET_DRIVE_STATUSmessage lets Settings show "Connected as …" on load, with Reconnect and Disconnect buttons. Both new messages are only reachable from extension pages; they are not on the content-script allowlist.result.emailfrom the response wrapper instead ofres.data.email, so "Connected as …" never appeared after connecting.docs/PRIVACY.mdanddocs/privacy.html): documents Disconnect; last-updated date is now September 27, 2026.tests/releaseDocs.test.tsguards both.store/MANIFEST_NOTES.mdno longer sayskeymust stay. The owner checklist anddocs/GOOGLE_DRIVE_SETUP.mdnow say to registerhttps://<store-item-id>.chromiumapp.org/after the first upload. Without that, Drive sign-in fails for store installs because the store assigns a different ID.Verification
npm run release-check: typecheck clean, 674/674 tests pass (4 new Drive tests), build succeeds, package check passes.subsume.zip(nokey) in headless Chromium:Owner follow-up (unchanged, see
store/WHAT_YOU_STILL_DO.md)Developer account and fee, OAuth consent screen in production, the store-ID redirect URI after the first upload, screenshot review, upload and submit.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FHFhkzNyPBLTv6hU2PeX3e
Generated by Claude Code