feat(filters): add squish filter - #943
Merged
Merged
Conversation
harttle
reviewed
Aug 11, 2026
| export function squish (this: FilterImpl, v: string) { | ||
| const str = stringify(v) | ||
| this.context.memoryLimit.use(str.length) | ||
| return str.replace(/\s+/g, ' ').trim() |
Owner
There was a problem hiding this comment.
Not sure if the spaces trimed by .trim() is same with those \s matches, and whether the order of replace and trim matters (it's different with shopify).
Anyway this is good enough to merge. Will handle it when discrepancies arise.
|
🎉 This PR is included in version 10.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
squishis a standard Shopify/liquid string filter and LiquidJS doesn't have it, so{{ "Hello World!" | squish }}currently renders unchanged rather thanHello World!.Strips leading and trailing whitespace and collapses each internal run to a single space, matching Shopify/liquid 5.12.0. Added alongside
strip_newlinesinsrc/filters/string.ts, with docs and a sidebar entry.Verified against all 17
squishcases in golden-liquid, which tests against Shopify/liquid as the reference implementation. All pass. 1588 tests pass here; the new tests fail on revert.