feat: add an actionable optional-import guard with install hints - #241
feat: add an actionable optional-import guard with install hints#241hasansezertasan wants to merge 3 commits into
Conversation
Bare imports of lazily-loaded component modules (web/tui/mcp/worker) in the CLI launcher surfaced a raw ModuleNotFoundError with no hint about how to fix it, whether from a library user missing an optional accelerator or a downstream project that toggled a component on via `copier update` without re-syncing. `core/_imports.require()` reports the actually-missing module and the exact install command instead.
|
Warning Review limit reached
Next review available in: 48 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c97698a9a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
core/_imports.require(module, *, feature, extra=None): imports an optional/lazy dependency or raises aModuleNotFoundErrornaming the actually-missing module (via the original exception'sname) and the exactpip installcommand, instead of a bare traceback.interactive/web/mcp/worker, both the Typer and argparse variants, plus the minimal launcher's default callback) and the corresponding component of thedefault()callback used wheninclude_cliis off. The GUI subcommand is left unguarded since it only depends on stdlibtkinter.docs/template-architecture.mdunder thecore/package.Closes #172
Test plan
preset=full(copier copy --data-file .example-input.yml --data preset=full --defaults --trust . /tmp/test-172)uv run --locked tox run -e stylepasses (ruff, mypy, basedpyright, ty, pyrefly, zuban, pylint, slotscheck, import-linter, taplo, typos, editorconfig-checker, sphinx-lint, deadfixtures)uv run --locked tox runpasses across all Python envscoverage reportshows 100% (gate isfail_under = 99)