Skip to content

feat(template): add PR task-list completion check - #32

Merged
hasansezertasan merged 2 commits into
mainfrom
feat/sweltering-shampoo
Jun 24, 2026
Merged

feat(template): add PR task-list completion check#32
hasansezertasan merged 2 commits into
mainfrom
feat/sweltering-shampoo

Conversation

@hasansezertasan

Copy link
Copy Markdown
Owner

Description

Adopts kentaro-m/task-completed-checker-action into the template so every generated project ships a check that fails while any task-list checkbox in a PR description remains unticked.

Changes

  • template/.github/workflows/task-completed-check.yml — new workflow on pull_request_target (opened/edited), SHA-pinned action (@2ddb65f # v0.1.2), least-privilege checks: write + pull-requests: read so it also runs on fork PRs.
  • template/.github/pull_request_template.md — wrapped the categorical "Types of changes" list in <!-- ignore-task-list-start/end --> so only the genuine pre-review checklist gates the PR (otherwise every PR would fail on the intentionally-unticked categorical boxes).
  • template/CONTRIBUTING.md.jinja — new "Required status checks" setup step listing the Validate PR title and Task Completed Checker check-run contexts; renumbered the following steps.
  • README.md / CLAUDE.md — documented the new check.

Verification

  • actionlint passes on the workflow.
  • Regenerated example/ (gitignored): the static workflow renders byte-identical, the PR template carries the ignore markers, and CONTRIBUTING renumbers cleanly 1–5.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @hasansezertasan, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f294c70a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread template/.github/workflows/task-completed-check.yml Outdated
Adopt kentaro-m/task-completed-checker-action so generated projects gate
PRs on completed task lists. Wrap the categorical "Types of changes" list
in the PR template with ignore markers so only the pre-review checklist is
enforced, and document the new required status check in CONTRIBUTING.
@hasansezertasan
hasansezertasan force-pushed the feat/sweltering-shampoo branch from 9f294c7 to 067c3df Compare June 24, 2026 17:00
A required Task Completed Checker status check would otherwise block PRs
after a plain push (synchronize fires no opened/edited event), leaving
branch protection waiting on a status that never reports.
@hasansezertasan
hasansezertasan merged commit 0fdb7aa into main Jun 24, 2026
6 checks passed
@hasansezertasan
hasansezertasan deleted the feat/sweltering-shampoo branch June 24, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant