Fix CI build issues: resolve yarn version conflicts and hash-value de…#691
Fix CI build issues: resolve yarn version conflicts and hash-value de…#691
Conversation
…pendency - Remove unpublished hash-value npm package, add local helper function - Fix CI yarn version conflicts by removing .yarnrc.yml in CI and using corepack - Add timeout to prevent hanging tests - Update import paths to use local hash-value helper
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
There was a problem hiding this comment.
Pull request overview
This PR resolves CI build issues by addressing yarn version conflicts and replacing an external dependency with a local implementation. The changes update the CI workflow to use Corepack for yarn version management and replace the hash-value npm package with a custom TypeScript implementation.
Changes:
- Removed the
hash-valueexternal dependency from package.json - Created a local
hash-valuehelper function to replace the removed dependency - Updated CI workflow to use Corepack with Node.js 18 and actions/setup-node@v4
- Added
.yarnrc.ymlto specify yarn version path
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| web/package.json | Removed hash-value dependency |
| web/app/services/product-areas.ts | Updated import to use local hash-value helper |
| web/app/helpers/hash-value.ts | Added custom hash-value implementation |
| web/.yarnrc.yml | Added yarn version configuration |
| .github/workflows/ci.yml | Modernized CI workflow with Corepack and updated Node.js/actions versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Remove .yarnrc.yml to let corepack handle yarn version | ||
| rm -f .yarnrc.yml |
There was a problem hiding this comment.
The workflow removes .yarnrc.yml that was just added to the repository. This creates confusion about which yarn version management approach is being used. Either keep .yarnrc.yml and use it consistently, or remove it from the repository if Corepack should manage versions.
| # Remove .yarnrc.yml to let corepack handle yarn version | |
| rm -f .yarnrc.yml |
| - name: Run web test | ||
| run: make web/test | ||
| - name: Run web test (with timeout) | ||
| run: cd web && timeout 10m yarn test:ember |
There was a problem hiding this comment.
The timeout command may not be available on all CI runners (e.g., macOS). Consider using the workflow-level timeout-minutes setting instead for better cross-platform compatibility.
2 participants
No description provided.