Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/components/package.json
Outdated
| "@codemirror/state": "^6.5.0", | ||
| "@codemirror/view": "^6.36.2", | ||
| "@ember/render-modifiers": "^2.1.0", | ||
| "@ember/render-modifiers": "^3.0.0", |
There was a problem hiding this comment.
This major version of render-modifiers drops support for ember < 4.12.
If we need this change for the v6.4 upgrade we'd have to keep this PR open and batch it with the rest of major changes for the next breaking release of our component library (v5).
There was a problem hiding this comment.
good question, let me see if it was just technical change or real one
There was a problem hiding this comment.
by the sound of it it's just mainly technical emberjs/ember-render-modifiers#81 (comment) , but I think we can keep it on 2.1 but it will show some pnpm warnings, also if you can added to the team backlog and rules to stop using this package all together and move to https://github.com/ember-modifier/ember-modifier, here is explainer why https://www.youtube.com/watch?v=zwewg2xmpU8
There was a problem hiding this comment.
Let's try 2.1 and see if it works. We have an epic for migrating away from deprecated dependencies covering ember-modifier as well
3 participants
📌 Summary
Update
showcase,websiteandcomponentsto new LTS ember 6.4🛠️ Detailed description
ember-source&ember-clito 6.4 and run blueprintI needed to bump some minor or patch deps version to satisfy peerDeps
@embroider/*@ember/render-modifiers- tho we should move away for this@nullvoxpopuli/ember-composable-helpersember-modifierember-power-select&ember-basic-dropdownember-concurrency[side-note]: I did not upgrade
@glimmer/componentsto v2 as per blueprint because it drop support for ember 3.28📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.