add ScalingPolicyOnErrorScale#623
Open
erulabs wants to merge 2 commits into
Open
Conversation
Contributor
|
Just noting here that there are some discussion in #622. If anyone has more ideas or feedback feel free to include them there 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feature request #622
Adds a new
on_errorvalue for scaling checks which allowson_error = "scale". This value means that when metrics fail to be collected (syntax error, no metrics, datadog downtime), we can specify a check that should fail-safe - ie: scale towards max.Some context: Datadog outage occurred right around our scale-up time - a lack of metrics meant nomad-autoscaler did nothing. We'd like it to fail open and automatically scale towards max when something has gone wrong.
This is a WIP and is currently missing tests - would love a hand or feedback!