Preserve pack metadata for jobs with top-level blocks like locals#892
Open
gautamg795 wants to merge 2 commits into
Open
Preserve pack metadata for jobs with top-level blocks like locals#892gautamg795 wants to merge 2 commits into
gautamg795 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nomad Pack injects
pack.*metadata into rendered job files so laterplan,run,stop, anddestroycommands can identify jobs managed by the same pack deployment.The metadata injection path currently parses the rendered file with a schema that only permits top-level
jobblocks. If a valid Nomad job file also contains another top-level block, such aslocals, that parse reports diagnostics and Nomad Pack skips metadata injection. The job can still be submitted, but it loses thepack.*metadata and future Nomad Pack operations treat it as unmanaged.This changes the metadata injection parser to use
PartialContent, so it can find top-leveljobblocks while preserving unrelated top-level HCL blocks. A regression test covers a job file with top-levellocals.Reminders
CHANGELOG.mdentryChanges to Security Controls
No. This does not change access controls, encryption, logging, or other security controls.