Skip to content

Feature/subtask2b consul tests#901

Open
DeekshithaTimmareddy wants to merge 3 commits into
feature/external-variable-sourcesfrom
feature/subtask2b-consul-tests
Open

Feature/subtask2b consul tests#901
DeekshithaTimmareddy wants to merge 3 commits into
feature/external-variable-sourcesfrom
feature/subtask2b-consul-tests

Conversation

@DeekshithaTimmareddy

@DeekshithaTimmareddy DeekshithaTimmareddy commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Description

Adds integration tests for the ConsulSource introduced in #898. Tests run against a real in-process Consul agent using consul/sdk/testutil — no mocks, no stubs.

The unit test file (consul_source_test.go) is removed; all coverage is now through integration tests that exercise the actual HTTP path.

Changes

  • consul_source_integration_test.go — 9 subtests covering:
    • Fetching typed variables (number, string, bool, object) from a KV path
    • Keys not in pack schema are ignored
    • Empty value for non-string variable returns an error
    • Object variable with optional field missing converts correctly via ConstraintType
    • Bool variable decoded from JSON
    • Malformed JSON for non-string variable returns an error
    • Empty string kept for string variable
    • Path with no keys returns empty result

Reminders

  • Add CHANGELOG.md entry
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@DeekshithaTimmareddy DeekshithaTimmareddy force-pushed the feature/subtask2b-consul-tests branch from ab8dbde to b47cb82 Compare June 19, 2026 18:20
@DeekshithaTimmareddy DeekshithaTimmareddy marked this pull request as ready for review June 19, 2026 18:34
@DeekshithaTimmareddy DeekshithaTimmareddy requested review from a team as code owners June 19, 2026 18:34

@tgross tgross left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is targeting the wrong branch. LLM-generated PR description. Tests don't pass.

@DeekshithaTimmareddy DeekshithaTimmareddy changed the base branch from main to feature/external-variable-sources June 22, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants