Refactor Run resource to use Iterator pattern#86
Open
NimishaShrivastava-dev wants to merge 3 commits intohashicorp:mainfrom
Open
Refactor Run resource to use Iterator pattern#86NimishaShrivastava-dev wants to merge 3 commits intohashicorp:mainfrom
NimishaShrivastava-dev wants to merge 3 commits intohashicorp:mainfrom
Conversation
|
|
isivaselvan
reviewed
Feb 20, 2026
| print(f"Total runs fetched: {len(run_list)}") | ||
| print() | ||
|
|
||
| for run in run_list.items: |
Collaborator
There was a problem hiding this comment.
Share the output results of examples/run.py file in the conversation.
isivaselvan
reviewed
Feb 20, 2026
| value: str = Field(..., alias="value") | ||
|
|
||
|
|
||
| class RunList(BaseModel): |
Collaborator
There was a problem hiding this comment.
Add back the RunList and OrganizationRunList models.
There was a problem hiding this comment.
restored these models
isivaselvan
reviewed
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converted the run resource listing methods to use the Iterator pattern instead of returning ModelList objects.
Changes
Runs.list()to returnIterator[Run]Runs.list_for_organization()to returnIterator[Run]_list()helper for pagination_list()and verify data transformationTesting
Related
Aligns with iterator pattern used in policy_evaluation and oauth_token resources