Refactored Run_event.py to iterator pattern#97
Open
NimishaShrivastava-dev wants to merge 1 commit intohashicorp:next-0.1.3from
Open
Refactored Run_event.py to iterator pattern#97NimishaShrivastava-dev wants to merge 1 commit intohashicorp:next-0.1.3from
NimishaShrivastava-dev wants to merge 1 commit intohashicorp:next-0.1.3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the RunEvents service to use the iterator pattern for its list method, consistent with the approach used in Runs and OAuthTokens.
Updated the run events example script to consume the new iterator-based API.
Added and improved unit tests for RunEvents to cover iterator behavior, input validation, and edge cases.
Ensured all tests, formatting, and linting checks pass.
Details
The list method in RunEvents now yields RunEvent objects directly, supporting efficient and memory-friendly iteration.
Example and tests were updated to us
the new iterator interface.
All checks (formatting, linting, and tests) pass successfully.