fix: Allow RunListOptions to be populated by name#98
Open
vaxvms wants to merge 1 commit intohashicorp:mainfrom
Open
fix: Allow RunListOptions to be populated by name#98vaxvms wants to merge 1 commit intohashicorp:mainfrom
vaxvms wants to merge 1 commit intohashicorp:mainfrom
Conversation
We should be able to declare a RunListOption as this RunListOptions(status=RunStatus.Run_Planned) and have the status parameter set in the resulting http query
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be able to declare a RunListOption as this RunListOptions(status=RunStatus.Run_Planned)
and have the status parameter set in the resulting http query
Description
RunListOptionsmodel doesn't accept field name, only alias while any other models allow it.Testing plan
This code doesn't filter run by status
External links
None
Output from tests
Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.
Rollback Plan
None
Changes to Security Controls
None
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
If you have any questions, please contact your direct supervisor, GRC (#team-grc), or the PCI working group (#proj-pci-reboot). You can also find more information at PCI Compliance.