Add creation and vending of dynamic team tokens#14
Open
dpowley wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a backwards-compatible role field called
token_typeto distinguish between the types of TFC token vending that this secrets engine handles:userorganizationteamThis PR also adds a new
token_type:dynamic_team. With this method, Vault will create revocable, time-bound teams under a TFC organization and vend tokens for those teams. The permissions for the teams that Vault creates are configured on the Vault role using theteam_optionsfield. For reference, here is an example Vault role configuration:I also upgrade the
go-tfepackage in order to recognize the most current organization and workspace permissions for thedynamic_teamtoken type.