feat: Implement open htlm report in browser by defaul#11
Merged
hasip-timurtas merged 3 commits intoJun 23, 2025
Merged
Conversation
- Added new dependencies including `bstr`, `dbus`, `libdbus-sys`, `normpath`, and `opener` to Cargo.toml and Cargo.lock for improved functionality. - Updated the solsec scan command to include a `--no-open` flag, allowing users to prevent automatic opening of HTML reports in CI environments. - Enhanced README.md to document the new `--no-open` option and clarify the behavior of automatic browser opening based on the environment. These changes improve the tool's usability and ensure it meets the needs of both interactive and automated workflows.
…mand - Revised the README.md to enhance clarity in the usage instructions for the `solsec scan` command, including adjustments to the descriptions of output formats and browser opening behavior. - Removed redundant phrases and ensured consistent language throughout the documentation. These changes improve user understanding and streamline the documentation for the solsec tool.
…to-scan-generate-json-and-html-reports
🛡️ Security Scan Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to control browser opening behavior for HTML reports, refactors the CLI configuration for better maintainability, and updates documentation to reflect these changes. The most significant updates include adding a
--no-openflag, restructuring theScanConfigto centralize configuration management, and enhancing the user experience with clearer documentation and examples.New Feature: Browser Opening Control
--no-openflag to prevent automatic opening of HTML reports in the browser. This flag is useful for CI environments and automation workflows. (src/cli.rs,README.md) [1] [2] [3] [4] [5] [6] [7]Refactoring: Centralized Configuration
ScanConfigstruct to encapsulate all scan-related configurations, simplifying thehandle_scan_commandfunction and improving maintainability. (src/cli.rs,src/main.rs) [1] [2] [3]Documentation Updates
README.mdto reflect the new--no-openflag, clarify browser opening behavior, and improve examples for better user understanding. (README.md) [1] [2] [3] [4] [5]Dependency Addition
openercrate to handle cross-platform browser opening for HTML reports. (Cargo.toml)Minor Enhancements
PartialEqto theReportFormatenum to support comparisons, which is used in determining browser opening conditions. (src/report.rs)