fix spacing issues while refactor-reduce#4841
Conversation
|
while working on this issue i also gathered the following observation that
triggering it on the below example does nothing (But constantly shows warning)
while for example 2 (Below) we do observe expected result from -- Example 2 before remove redundant constraint
j :: (Eq a, Show a) => a -> a
j x = xto -- Example 2 after remove redundant constraint
j :: a -> a
j x = xi did try and fix this but could not !! to be specific Requesting a look at it if worthwhile @fendor |
|
|
|
Error logs stated that it failed due to resource vanish ( broken pipe ) Should i look into it ? ( any possibility of optimisation like call-hierarchy ? ) |
We try to address this kind of error in #4701 Dont investigate, I don't think it is worth it |
fendor
left a comment
There was a problem hiding this comment.
LGTM, tbh, I am relying on the test suite for correctness, because I can't tell without serious tinkering whether this is correct.
Thank you for fixing this!

Fixes #4825
In the previous implementation
resetEntryDPfunction was triggered when reduction code action removed any leading constraint from the context. This lead to inconsistent spacing for this scenario.fixes this by
resetEndtryDPfunction ( fixes removal of space after => )