Fix transitiveReverseDependencies recursion#4946
Open
crtschin wants to merge 2 commits into
Open
Conversation
new was inverted so the recursion never expanded past the first step, leaving typecheckParents to refresh only direct importers on save.
crtschin
force-pushed
the
crtschin/transitive-typecheck-fix
branch
from
d6a1930 to
a1ea57e
Compare
Collaborator
Author
|
I'll drop the first commit once #4947 lands |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newwas inverted so the recursion never expanded past the first step, leavingtypecheckParentsto refresh only direct importers on save.