Skip to content

Only advertise semanticTokens if there's a handler #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fendor merged 1 commit into from
May 16, 2026
+11 −5
Merged

Only advertise semanticTokens if there's a handler #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lsp/src/Language/LSP/Server/Processing.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,12 +399,18 @@ inferServerCapabilities _clientCaps o h =
Just cmds -> ExecuteCommandOptions clientInitiatedProgress cmds
Nothing -> error "executeCommandCommands needs to be set if a executeCommandHandler is set"

-- Always provide the default legend
-- Only advertise semantic tokens if the server has registered a handler for
-- at least one of the semantic-token request methods. Otherwise clients that
-- honor server capabilities (e.g. Neovim's built-in LSP client) will fire
-- requests we can't answer, producing spurious "no handler for" errors.
-- TODO: allow user-provided legend via 'Options', or at least user-provided types
semanticTokensProvider =
Just $
InL $
SemanticTokensOptions clientInitiatedProgress defaultSemanticTokensLegend semanticTokenRangeProvider semanticTokenFullProvider
semanticTokensProvider
| supported_b SMethod_TextDocumentSemanticTokensFull
|| supported_b SMethod_TextDocumentSemanticTokensRange =
Just $
InL $
SemanticTokensOptions clientInitiatedProgress defaultSemanticTokensLegend semanticTokenRangeProvider semanticTokenFullProvider
| otherwise = Nothing
semanticTokenRangeProvider
| supported_b SMethod_TextDocumentSemanticTokensRange = Just $ InL True
| otherwise = Nothing
Expand Down
Loading