Merged
Conversation
- Minimal correct modification to `CRMS::GetNextItemForReview` I could come up with - Split `ORDER BY` parameters into "critical" and "noncritical" - Any project-supplied `ORDER BY`s get prepended to the noncritical array. - Remove obsolete comment. - Add `params` arrays for both of the new arrays to address an existing (and commented-on) parameter land mine. This helps ensure clauses and their parameters get assembled in the right order.
liseli
approved these changes
Nov 10, 2025
liseli
left a comment
liseli
left a comment
There was a problem hiding this comment.
I'll approve this PR because the change make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be about the smallest bugfix PR I am capable of producing. Has been tested on dev-2 against the production database and the results are now correct.
CRMS::GetNextItemForReviewORDER BYparameters into "critical" and "noncritical"ORDER BYs get prepended to the noncritical array.paramsarrays for both of the new arrays to address an existing (and commented-on) parameter land mine. This helps ensure clauses and their parameters get assembled in the right order.GetNextItemForReviewthat, alas, doesn't really test the bugfix, just that the code can still produce a correct output.For the Reviewer
In a nutshell, CRMS is calling
SELECT ... FROM queue WHERE ...with a bunch ofORDER BYconstraints and the optionalORDERcalled$porderneeds to be in the middle of the list. Hence the split into "critical" and "noncritical".The added
@critical_order_paramsand@noncritical_order_paramsis insurance against future bugs, it is not really part of the bugfix. The existing parameter handling was just... not nice.