Rich text & course design dark mode revisions #780
Rich text & course design dark mode revisions #780kchar601 wants to merge 10 commits intohaxtheweb:masterfrom
Conversation
Updated pre, mark, abbr, to support dark mode alternatives (to avoid jarring contrast). Started digging into course-design elements to help give dark mode support
updated learning components to support a dark mode alternative. changed border color to match title background color for a more integrated look & feel (helps with dark mode too). integrated DDD into activity box including using primary & accent to create the gradient (not sure if it gets used anymore)
|
@kchar601 is attempting to deploy a commit to the HAXTheWeb Team on Vercel. A member of the Team first needs to authorize it. |
|
fixes #2595 |
btopro
left a comment
There was a problem hiding this comment.
have 3 questions, they dont seem to be required in the way they are done. confirm / remove / etc and then I think this is probably good to go
|
but there are solutions in here to dark mode support in other elements as well. Please open issues and associate for these even if it's just like |
Removed unnecessary updated method override.
the super and 18n changes we're me duplicating the setup of other components when I couldn't get --ddd-theme-primary to be accessible in the styling for activity-box, if they're unrequired, they can be removed. The change for adding the data-font-size was a half baked attempt to remove hardcoded variables in favor of having the size of the entire component be somewhat variable, but can be removed as that was not implemented. |
|
closes #2615 |
Also confusing with the screenshot I took - activity box is the component with the gradient background - learning-component is the one at the top with the orange title banner for the heading. |
|
closes #2611 |
|
haxtheweb/issues#2611 needs a dedicated area for examples of the different styles of line not just color being there. Like a whole container that just illustrates the ways to decorate headings and hr's |
|
let me know when this PR is ready for review fully. I think there are still some outstanding things associated with it |

Rich Text
Previous Design:
New Changes:
Course Design Elements
Previous Design:
New Changes: