Skip to content

Rich text & course design dark mode revisions #780

Open
kchar601 wants to merge 10 commits intohaxtheweb:masterfrom
kchar601:richTextRevisions
Open

Rich text & course design dark mode revisions #780
kchar601 wants to merge 10 commits intohaxtheweb:masterfrom
kchar601:richTextRevisions

Conversation

@kchar601
Copy link
Contributor

@kchar601 kchar601 commented Mar 5, 2026

Rich Text

Previous Design:

New Changes:


    • Added dark mode alternative for pre element
    • Added styling to ensure pre doesn't overflow containers - but continues to maintain the pre-spaced styling
    • Added styling to ensure mark spacing styling wasn't being cut off awkwardly between line breaks
    • Added dark mode alternative coloring for mark - maintains highlighted feel but less drastic for darker screens [up for debate]
    • Made abbr default coloring match with default info. More inline with info coloring & distinguishes from being used in place of mark
    • Added demo text of other html rich texts elements (sup, sub, del, ins, s)

Course Design Elements

Previous Design:

New Changes:


    • Added dark mode alternative for learning component & block-quote
    • For learning component, changed border to match title background for stronger association between title and content
    • Added DDD integration to activity box (primary & accent create new gradient but only if both are present) [not sure if component is depricated]
    • changed link positioning in learning component to ensure link is always in the bottom left hand corner of content box

kchar601 added 5 commits March 3, 2026 22:29
Updated pre, mark, abbr, to support dark mode alternatives (to avoid jarring contrast). Started digging into course-design elements to help give dark mode support
updated learning components to support a dark mode alternative. changed border color to match title background color for a more integrated look & feel (helps with dark mode too).
integrated DDD into activity box including using primary & accent to create the gradient (not sure if it gets used anymore)
@kchar601 kchar601 requested a review from btopro as a code owner March 5, 2026 05:36
@vercel
Copy link

vercel bot commented Mar 5, 2026

@kchar601 is attempting to deploy a commit to the HAXTheWeb Team on Vercel.

A member of the Team first needs to authorize it.

@kchar601
Copy link
Contributor Author

kchar601 commented Mar 5, 2026

fixes #2595

Copy link
Member

@btopro btopro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have 3 questions, they dont seem to be required in the way they are done. confirm / remove / etc and then I think this is probably good to go

@btopro
Copy link
Member

btopro commented Mar 5, 2026

haxtheweb/issues#2595

but there are solutions in here to dark mode support in other elements as well. Please open issues and associate for these even if it's just like activity-box needs dark mode support and then it effectively gets closed with this PR. This still documents a reasonable change log of enhancements and credits you with more work :)

@kchar601
Copy link
Contributor Author

kchar601 commented Mar 6, 2026

have 3 questions, they dont seem to be required in the way they are done. confirm / remove / etc and then I think this is probably good to go

the super and 18n changes we're me duplicating the setup of other components when I couldn't get --ddd-theme-primary to be accessible in the styling for activity-box, if they're unrequired, they can be removed.

The change for adding the data-font-size was a half baked attempt to remove hardcoded variables in favor of having the size of the entire component be somewhat variable, but can be removed as that was not implemented.

@kchar601
Copy link
Contributor Author

kchar601 commented Mar 6, 2026

closes #2615

@kchar601
Copy link
Contributor Author

kchar601 commented Mar 6, 2026

haxtheweb/issues#2595

but there are solutions in here to dark mode support in other elements as well. Please open issues and associate for these even if it's just like activity-box needs dark mode support and then it effectively gets closed with this PR. This still documents a reasonable change log of enhancements and credits you with more work :)

Also confusing with the screenshot I took - activity box is the component with the gradient background - learning-component is the one at the top with the orange title banner for the heading.

@kchar601 kchar601 requested a review from btopro March 6, 2026 03:11
@kchar601
Copy link
Contributor Author

kchar601 commented Mar 6, 2026

closes #2611

@btopro
Copy link
Member

btopro commented Mar 6, 2026

haxtheweb/issues#2615

@btopro
Copy link
Member

btopro commented Mar 6, 2026

haxtheweb/issues#2611 needs a dedicated area for examples of the different styles of line not just color being there. Like a whole container that just illustrates the ways to decorate headings and hr's

@btopro
Copy link
Member

btopro commented Mar 6, 2026

image

@btopro
Copy link
Member

btopro commented Mar 6, 2026

let me know when this PR is ready for review fully. I think there are still some outstanding things associated with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants