Skip to content

Remove language 'go' from README #472

Merged
srknzl merged 1 commit into
hazelcast:masterfrom
gbarnett-hz:fix-readme-for-go-generation
Aug 15, 2023
Merged

Remove language 'go' from README #472
srknzl merged 1 commit into
hazelcast:masterfrom
gbarnett-hz:fix-readme-for-go-generation

Conversation

@gbarnett-hz
Copy link
Copy Markdown
Contributor

@gbarnett-hz gbarnett-hz commented Aug 14, 2023

./generator.py -l go doesn't work despite being listed as a language target in README.md.

From what I see the README is incorrect as the golang support looks minimal to non-existant. This PR just remove go from stated set of language targets.

You can generate codecs for a specific language by calling,

./generator.py [-r ROOT_DIRECTORY] [-l LANGUAGE] [-p PROTOCOL_DEFS_PATH] [-o OUTPUT_DIRECTORY] [-n NAMESPACE] [-b BINARY_OUTPUT_DIR] [-t TEST_OUTPUT_DIR] [--no-binary] [--no-id-check]
where

ROOT_DIRECTORY is the root folder for the generated codecs. If left empty, default value is set to ./output/[LANGUAGE].

LANGUAGE is one of

java : Java
cpp : C++
cs : C#
py : Python
ts : TypeScript
go : Go
md : Markdown (Documentation)

./generator.py -l go
usage: generator.py [-h] [-r ROOT_DIRECTORY] [-l LANGUAGE] [-p PROTOCOL_DEFS_PATH] [-o OUTPUT_DIRECTORY] [-n NAMESPACE] [-b BINARY_OUTPUT_DIRECTORY]
                    [-t TEST_OUTPUT_DIRECTORY] [--no-binary] [--no-id-check]
generator.py: error: argument -l/--lang: invalid choice: 'go' (choose from 'java', 'cpp', 'cs', 'py', 'ts', 'md')

Fixes: #471

@ihsandemir
Copy link
Copy Markdown
Collaborator

@yuce ?

@yuce
Copy link
Copy Markdown
Collaborator

yuce commented Aug 15, 2023

Go client support is in this PR: #420
But I don't see it to be merged in the near future, so it's OK to remove go from the README.

@gbarnett-hz
Copy link
Copy Markdown
Contributor Author

@yuce + @ihsandemir could you approve this PR then?

@srknzl srknzl merged commit 58c3b24 into hazelcast:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go generation not working

4 participants