Add autoStepDownWhenLeader to MemberInfo [CORE-216]#545
Conversation
| type: Map_EndpointQualifier_Address | ||
| nullable: false | ||
| since: 2.0.1 | ||
| - name: autoStepDownWhenLeader |
There was a problem hiding this comment.
| - name: autoStepDownWhenLeader | |
| - name: cpAutoStepDownWhenLeader |
There was a problem hiding this comment.
agree that prefixing with cp makes it more understandable, especially for the future readers.
gareth-johnston
force-pushed
the
CORE-216/abdicating-leadership
branch
from
daccd74 to
83d5aaa
Compare
There was a problem hiding this comment.
I agree with @ihsandemir that prefixing with cp makes sense, to provide extra clarity - approving in advance though 👍
Do you think that is still relevant now? That comment was relating to when we were changing |
Ah, apologies - no I don't think it's relevant in that case, all good to go from my POV |
|
PR closed by Hazelcast automation as no activity (>3 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions |
gareth-johnston
force-pushed
the
CORE-216/abdicating-leadership
branch
from
22571cd to
289e0a7
Compare
Adds new feature to prevent undesirable members leading a `Raft Group` in the `CPSubsystem`. A node configured with `autoStepDownWhenLeader` follows a new code path which : 1/ Refuses Replication OPs. 2/ Invokes an immediate leadership rebalancing procedure to transfer leadership to higher priority node. This change ensures that: 1/ Such a member can lead the `METADATA` group. 2/ Such a member will not have a Raft Group rebalanced to it. 3/ A Raft Group can not be created with exclusively members configured with `autoStepDownWhenLeader` (always prioritizing leader capable members from the pool). 4/ Initial election on term 0 is avoided by nodes configured with `autoStepDownWhenLeader` 5/ Can be configured both by programatic and static Configurations. 6/ Testing has been added for various cases and Improvements in unit testing for various classes. 7/ Requires majority leader-capable nodes on discovery, group creation and promotion. Small follow up changes to come in later work. ClientProtocol changes: hazelcast/hazelcast-client-protocol#545 Checklist: - [X] Labels (`Team:`, `Type:`, `Source:`, `Module:`) and Milestone set - [X] Architecture Design Record (ADR) reviewed and signed-off if this PR represents a significant architectural change - [X] Request reviewers if possible GitOrigin-RevId: 7700a31506071a0ea9f7ac5f3ac2e86872165169
gareth-johnston
dismissed
ihsandemir’s stale review
Outdated - hasn't responded
| - name: autoStepDownWhenLeader | ||
| type: boolean | ||
| nullable: false | ||
| since: 2.9 |
There was a problem hiding this comment.
This should be 2.10 for 5.7. 2.9 was used for platform 5.6.
Adds
autoStepDownWhenLeaderboolean added to MemberInfo