Repository navigation
fix(evals): place a pnpm catalog's commits on their Angular major - #10
Merged
Merged
Conversation
In a catalog project package.json only says catalog:, so every commit read as landing on no major, and the catalog case's one-commit-per-major check failed a run that had committed Angular 21 correctly. The version now comes from the commit's pnpm-workspace.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The catalog case's one-commit-per-major check failed a run that did everything right. In a pnpm catalog project,
package.jsononly says"@angular/core": "catalog:", so the grader read every commit as landing on no major. The version now comes from that commit'spnpm-workspace.yaml.Checked
^21.2.0from a catalog, past another entry and a trailing comment, and a plainpackage.jsonreads as before.upgrade-pnpm-catalogwith the skill scored 13/14. Its one commit is "chore(deps): upgrade to Angular 21", and the catalog check on the same run found@angular/coreat 21. This is the only check it failed.