Repository navigation
feat(plan): name a file angular.json loads that the next release drops - #12
Merged
Merged
Conversation
The license check walked the tarball itself. The walk now lists every file once, and follows the ustar prefix field, where a path longer than 100 bytes continues, so a check for a deep file can't miss it.
marked 16 stopped shipping marked.min.js, which readme-wizard loaded from angular.json's scripts, and only the build said so. The plan now reads the scripts and styles every target loads from node_modules, checks each moving package's next release for them, and names a missing one under that major, with the troubleshooting section to follow. A release it can't read is listed as unchecked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marked16 stopped shippingmarked.min.js, which readme-wizard loaded fromangular.json, and only the build said so. The plan now reads the scripts and styles every target inangular.jsonloads fromnode_modules, checks each moving package's next release for them, and names a missing one under that major:Checked
npm testpasses. New tests cover a droppedmarked.min.jsnext to a file that stays, a path deep enough to need the prefix field (which fails without the prefix handling), and an unreadable tarball.