Repository navigation
fix: default-explain flags, check unreadable files, GitContext cwd - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardening pass for eoldoctor 0.1.4. No framework change.
Fixes
eoldoctor --json/eoldoctor <path>now runexplainwith those args (the default-command path used to drop every extra argument or reject a path as an invalid subcommand).checkfails on unreadable files (was info-only; CI gate returned 0).GitContext.list_filesresolves paths against the context cwd so the library API works when the process cwd is not the repo root.1/yes/onon Git < 2.40 (fallback when--type=bool-or-stris missing).attributes --writereports I/O errors and exits 1 instead of a traceback.Tests / lint / docs
compileallruns inside the existing unittest CI job.[tool.ruff]configured for localruff check(bug-oriented rules).v0.1.4.Workflow files under
.github/workflows/were not modified (token has noworkflowscope).Verification
python -m ruff check eoldoctor testspython -m unittest discover -s tests -t .— 164 tests OK locallypython -m eoldoctor check --require lf --forbid-bom --require-final-newlineon this repo: OK