fix: do not follow ../ refs out of the project - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动
check不再跟随../走出项目根目录去认外部图片。绝对路径如果解析后不在项目内，同样按缺失处理（MISSING_REF），避免 bible 把仓库外的文件当成合法 ref。与已有 draft「诚实写 PyYAML / 拒绝坏 take list」互补。本 PR 不 bump 版本（#1 已是 0.2.2）。
没有 PR 模板。
验证
PYTHONPATH=src python3 -m pytest -q→ 47 passed，含test_ref_escape.py。