Repository navigation
Conversation
Allow official sync clients to wait for updates without accepting unbounded client timeouts. Keep the published SlateDB binding and bound disconnected requests without adding notification state.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 93.22% 93.38% +0.15%
==========================================
Files 48 48
Lines 3321 3355 +34
==========================================
+ Hits 3096 3133 +37
+ Misses 225 222 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support nonzero
long_poll_timeout_ms, capped byMAX_LONG_POLL_TIMEOUT_MS(default 5000 ms). Return immediately for available updates, bootstrap, fixed revisions, and zero timeouts.Check SlateDB HEAD between sleeps of at most 100 ms. Release snapshots and leases before sleeping; recheck access before responding. No new locks, subscriptions, native patches, or dependencies.
Disconnected HTTP requests can wait until the deadline. The cap bounds waiting, not storage or response processing.
Validation:
bb verifypassed (231 tests, 1109 assertions); official SDK E2E passed, including capped responses, updates during waiting, and aborted-pull recovery.Related upstream draft: slatedb/slatedb#2198. This PR works with the current published binding.