Conversation
…age validation in CI Made-with: Cursor
✅ Deploy Preview for oeps canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #311
Summary
FileResourcehas norow_streamin frictionless-py) — see Frictionless validation breaks on data packages due to shapefile foreign keys #311.*-geography-keys.csvresource per geography (from the sameget_blank_dataframe()as the main tables) and pointsforeignKeysat that CSV instead of the shapefile.--skip-validationfrom the Create Data Packages workflow and drops theDSuite2023-only--skip-foreign-keysworkaround.How to test
backend/withFLASK_APP=oeps):pip install -e . flask create-data-package -c DSuite2018 --overwrite flask create-data-package -c DSuite2023 --overwriteOmit --skip-validation or --skip-foreign-keys. Confirm the command finishes with exit code 0 and the log ends with a validation summary showing 0 errors (tasks include *-geography-keys resources and geo shapefile resources).
Optional — inspect output
Open the generated folder under backend/.temp/data-packages/ (or your --destination) and check data-package.json: main CSV foreignKeys should reference {county|state|tract|zcta}-geography-keys, not geo-* shapefile names.
Confirm data/*-geography-keys.csv files exist next to the main geography CSVs.
CI
After merge, or on this branch: run the Create Data Packages workflow manually (workflow_dispatch) if package_rules did not change (no automatic run). Confirm the job succeeds.
Note on follow-up fixes
Validation is now enforced in CI instead of skipped. The first few runs after this change may surface new failures (e.g. schema/FK mismatches, data edge cases, or frictionless upgrades) that were previously hidden. If a workflow run fails, use the job logs and the generated error-report.json in the package output (when produced) to diagnose, then open a small follow-up PR to adjust package structure or data as needed. That tightening is expected and improves long-term package quality.