_statusItem dangles and setup + unsquashing of status image.#2
Open
lhunath wants to merge 7 commits intoheardrwt:masterfrom
Open
_statusItem dangles and setup + unsquashing of status image.#2lhunath wants to merge 7 commits intoheardrwt:masterfrom
lhunath wants to merge 7 commits intoheardrwt:masterfrom
Conversation
[FIXED] _statusItem wasn't retained. [FIXED] It's silly to make the application set up the status item's highlightMode and view; RHStatusItemView doesn't work properly without and can do it fine itself. [FIXED] Don't squash status image; center-crop, like the default behavior of NSStatusItem.image.
Author
|
Also, don't use alternateImage unless it's actually set. |
# By Maarten Billemont # Via Maarten Billemont * 'master' of https://github.com/lhunath/RHStatusItemView: fromRect: takes an NSRect, not a CGRect. _statusItem dangles and setup + unsquashing of status image.
Conflicts: RHStatusItemView.xcodeproj/project.pbxproj RHStatusItemView/RHStatusItemView.h RHStatusItemView/RHStatusItemView.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FIXED] _statusItem wasn't retained.
[FIXED] It's silly to make the application set up the status item's highlightMode and view; RHStatusItemView doesn't work properly without and can do it fine itself.
[FIXED] Don't squash status image; center-crop, like the default behavior of NSStatusItem.image.