fix: Optional Map go code generation for map[string]interface{}#146
Open
TypicalDefender wants to merge 1 commit intoheetch:masterfrom
Open
fix: Optional Map go code generation for map[string]interface{}#146TypicalDefender wants to merge 1 commit intoheetch:masterfrom
TypicalDefender wants to merge 1 commit intoheetch:masterfrom
Conversation
Contributor
|
Is that perhaps because a map in Go already has nil as a possibility so having a pointer to a map is arguably redundant? |
Author
Yes. Since a Go map's zero value is nil, it can already represent null. This change makes the generated code more idiomatic. Thanks for checking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
The code generator previously failed to correctly process Avro union types defined as
["null", {"type": "map", "values": "T"}]. When it encountered a schema with such a field, the generator's logic would overlook the"null"part of the union.As a result, it would generate a standard map type (e.g.,
map[string]string) instead of a pointer to a map (e.g.,*map[string]string), failing to represent the field's optionality. This led to a mismatch between the Avro schema and the generated Go struct, causing potential issues during data serialization and deserialization.Example of Incorrect Behavior
Let's consider the following Avro schema definition:
{ "type": "record", "name": "ExampleRecord", "fields": [ { "name": "mapTest", "type": ["null", {"type": "map", "values": "string"}] } ] }