fix: update Codex and Code Mode host together - #459
Open
marksverdhai wants to merge 3 commits into
Open
Conversation
Contributor
Coverage report
Per-file breakdownRaw |
marksverdhai
marked this pull request as ready for review
September 5, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex updates and version switches previously replaced only the CLI, leaving an older Code Mode host behind. With Codex 0.153.4 this caused
missing field code_mode_host_duration_nserrors even though commands executed.Use one release installer for automatic updates and both version-switch paths. It stages the CLI and matching helper from the same release, verifies published SHA256 digests, serializes installation, and restores the previous helper if installing the CLI fails. Older releases without any helper remove the stale helper. Source builds include the helper package when present; download/integrity/install failures no longer silently fall back to building a different version.
The executable replacements are individually atomic. Already-running Codex processes still need restarting after switching versions; this is documented.
Validation:
cargo testpasses (830 tests, 4 ignored); finalcargo test --lib agents::codexpasses (12 tests);cargo clippy --all-targets -- -D warnings,cargo fmt --all -- --check, andcargo build --releasepass.CI uses a newer Clippy than this machine and flagged an existing
chunks_exact(4)loop in the vector decoder. A separate two-line commit usesas_chunks::<4>()with equivalent behavior to keep CI passing.Closes #458.