Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates how FILE_DIR is determined in the Zsh config, replacing an external cd/dirname call with a native Zsh parameter expansion to avoid issues in certain environments like VSCode.
- Replaced legacy
cd+dirnamelogic with${${(%):-%N}:A:h}expansion. - Added comments explaining the switch to built-in path resolution.
Comments suppressed due to low confidence (1)
.config/zsh/zshrc:1
- [nitpick] This comment refers to the old method. Update it to describe the new Zsh parameter expansion approach for resolving the file's directory.
# directory fullpath of this file
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FILE_DIRTesting
pytest -qhttps://chatgpt.com/codex/tasks/task_e_687071cab650832b814b29e92a21a9bb