Skip to content

ci: fix first real run — create gen dest dir + Linux overlay dead code #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellno merged 2 commits into from
Jun 11, 2026
Merged

ci: fix first real run — create gen dest dir + Linux overlay dead code #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e55c38
ci: create the generate destination dir before rendering the template
hellno Jun 11, 2026
a3425a4
fix(overlay): gate submodules to macOS so Linux --features overlay is…
hellno Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ jobs:
# project confuses cargo, see rust-lang/cargo#9922). --silent uses the placeholder
# defaults (bundle_qualifier=com, bundle_org=example).
- name: Generate a project from the template
run: cargo generate --path . --name deck-ci --silent --vcs none --destination "$RUNNER_TEMP/gen"
run: |
mkdir -p "$RUNNER_TEMP/gen"
cargo generate --path . --name deck-ci --silent --vcs none --destination "$RUNNER_TEMP/gen"
# No toolchain pin here: rust-toolchain.toml (copied into the generated project) is
# the single source of truth; rustup auto-installs it on the first cargo call.
- uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1
Expand Down Expand Up @@ -88,7 +90,9 @@ jobs:
with:
tool: cargo-generate
- name: Generate a project from the template
run: cargo generate --path . --name deck-ci --silent --vcs none --destination "$RUNNER_TEMP/gen"
run: |
mkdir -p "$RUNNER_TEMP/gen"
cargo generate --path . --name deck-ci --silent --vcs none --destination "$RUNNER_TEMP/gen"
- uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1
with:
workspaces: ${{ runner.temp }}/gen/deck-ci
Expand Down Expand Up @@ -117,7 +121,9 @@ jobs:
with:
tool: cargo-generate,cargo-deny
- name: Generate a project from the template
run: cargo generate --path . --name deck-ci --silent --vcs none --destination "$RUNNER_TEMP/gen"
run: |
mkdir -p "$RUNNER_TEMP/gen"
cargo generate --path . --name deck-ci --silent --vcs none --destination "$RUNNER_TEMP/gen"
- name: cargo-deny check
working-directory: ${{ runner.temp }}/gen/deck-ci
run: cargo deny check advisories bans sources licenses
9 changes: 9 additions & 0 deletions src/overlay/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,19 @@
//! GPUI `Global`, then `cx.notify()`. `upgrade()` returning `None` is the natural
//! no-op after the overlay closes — no panic, no leaked task.

// macOS-only in v1: the overlay windows + their objc2 panel hardening only exist on
// macOS, so every consumer below is `#[cfg(target_os = "macos")]`. Gate the submodules
// to match — otherwise a Linux `--features overlay` build compiles them with zero users
// and clippy's `-D warnings` rejects the dead code. `install()` stays a no-op on Linux.
#[cfg(target_os = "macos")]
mod harden;
#[cfg(target_os = "macos")]
mod pill;
#[cfg(target_os = "macos")]
mod rail;
#[cfg(target_os = "macos")]
mod state;
#[cfg(target_os = "macos")]
mod status;

#[cfg(target_os = "macos")]
Expand Down