Lived-in walkman app icon + reproducible icon pipeline - #6
Merged
Conversation
- assets/icon.png: new 1024px squircle master (Apple padding + soft shadow) - assets/icon.icns: regenerated multi-res icon (16-1024, @1x/@2x) - Cargo.toml: point cargo-bundle at the .icns directly; a lone 1024px PNG has no matching icns IconType in cargo-bundle 0.11, which broke 'just bundle'
- scripts/make-app-icon.py: any source image -> squircle-masked, padded, shadowed .icns (true superellipse, pure Pillow) + optional Linux hicolor tree (--linux) and web rounded PNG (--web) - assets/icon-source.png: committed source so 'just icon' is reproducible - justfile: 'icon' now runs the script from icon-source.png; add 'icon-linux' - README / LEARNINGS / Cargo.toml: document image->squircle->icns, the icon-source.png drop point, and why the bundle points at icon.icns directly (cargo-bundle 0.11 can't build an icns from a lone 1024px PNG) - .gitignore: ignore /dist (generated Linux/web extras)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces Deck's placeholder app icon with a new "lived-in walkman" icon, and makes the icon toolchain reproducible and fork-clean.
Changes
New icon
assets/icon.{png,icns}— desert "used-future" walkman (warm cream/tan + burnt-orange, hazard decal, matte tactile buttons), baked into the macOS squircle tile with Apple-style padding + a soft drop shadow.Cargo.tomlbundle config now points atassets/icon.icnsdirectly — cargo-bundle 0.11 can't build an.icnsfrom a lone 1024² PNG (No matching IconType: 1024 only exists as 512@2x), which silently brokejust bundle.Reproducible, fork-clean pipeline
scripts/make-app-icon.py— turns any source image into a squircle-masked, padded, shadowed.icns(true continuous-corner superellipse, pure Pillow).--linuxalso emits a freedesktophicolortree +.desktop;--weba full-bleed rounded PNG.assets/icon-source.png— committed source art, sojust iconis reproducible.justfile—iconnow runs the script; addedicon-linux.docs/LEARNINGS.md/Cargo.toml— document theimage → squircle → icnsflow and theicon-source.pngdrop point..gitignore— ignore/dist(generated Linux/web extras).Fork flow (the point of this PR)
assets/icon-source.pngjust icon(bakes the macOS squircle + rebuildsicon.icns)just bundleTest plan
python3 scripts/make-app-icon.py→ regeneratesassets/icon.png+assets/icon.icns✓python3 scripts/make-app-icon.py --linux --web→dist/linux/hicolor/**+dist/icon-rounded.png✓cargo bundle→ validDeck.app, icon shows in the Dock ✓