Avoid chmod of missing ~/$HOME/$HELLO_FLEET_ID during factory installs

[hello-jkoubi]

Factory installs (-f) skip the local calibration directory check but still attempted to chmod $HOME/$HELLO_FLEET_ID, causing installs to fail when the directory is not present.

hello-robot@stretch-re2-2021:~/stretch_install$ ./stretch_new_robot_install.sh -f
[sudo] password for hello-robot:
#############################################
STARTING NEW ROBOT INSTALL
#############################################
WARNING: Running a FACTORY install. This is only meant to be run at Hello Robot HQ.
WARNING: Run this installation for fresh Ubuntu installs only.
Checking ~/.bashrc doesn't already define HELLO_FLEET_ID...
1) stretch-re1
2) stretch-re2
3) stretch-se3
Select model type: 2
Selected model: stretch-re2
Enter fleet id xxxx for stretch-re2-xxxx> 2021
HELLO_FLEET_ID will be stretch-re2-2021.
Plug in charger & attach clip-clamp before proceeding.
Ready to proceed with installation (y/n)? y
Checking Stretch Install cloned to right place...
chmod: cannot access '/home/hello-robot/stretch-re2-2021': No such file or directory

This change moves the chmod into the non-factory path, where the directory is required, and avoids touching the home-folder calibration path during factory installs.

[CLAassistant]

All committers have signed the CLA.

[hello-robot-shehab]

Shouldn't the user place that folder in the $HOME directory before running this script anyway? In other words, should the script fail if the robot folder is not present in the $HOME directory, instead of moving the chmod?

[hello-jkoubi]

Yes from the instructions the user should place that folder in $HOME directory but here i am running the factory install (-f flag) which is supposed to pull the calibration data from the stretch_fleet repo instead of hard copying the folder as the user is supposed to do, so this chmod command should be inside the if [ $do_factory_install = 'false' ] loop.

[hello-jkoubi]

Another thing that i would like to mention is that originally the calibration files are under /home/$USER/stretch_user/stretch-<yyy>-<xxxx> , then from our install instructions we put them back in the /home/$USER/stretch-<yyy>-<xxxx>/ which is different. Is that normal?