Skip to content

Add 2-hour timeout to CI jobs + fix test_io race condition#2147

Merged
brownbaerchen merged 2 commits into
2134-Prune_CI_matrixfrom
copilot/sub-pr-2139
Feb 24, 2026
Merged

Add 2-hour timeout to CI jobs + fix test_io race condition#2147
brownbaerchen merged 2 commits into
2134-Prune_CI_matrixfrom
copilot/sub-pr-2139

Conversation

Copilot AI commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

CI jobs had no timeout, risking runaway runs. test_load_zarr_group had a race condition where rank 0 would begin writing the zarr store for the next loop iteration before other MPI ranks finished assertions from the current one.

Changes

  • ci.yaml / ci_full.yaml: Add timeout-minutes: 120 to both CI jobs.
  • test_io.test_load_zarr_group: Insert ht.MPI_WORLD.Barrier() at the end of the for dtype loop body, ensuring all ranks complete each iteration's assertions before rank 0 starts writing the zarr store for the next dtype.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: brownbaerchen <39156931+brownbaerchen@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix deadlock in test_io and leaner CI matrix Add 2-hour timeout to CI jobs + fix test_io race condition Feb 24, 2026
Copilot AI requested a review from brownbaerchen February 24, 2026 13:29
@brownbaerchen brownbaerchen marked this pull request as ready for review February 24, 2026 14:49
@brownbaerchen brownbaerchen merged commit 118ed76 into 2134-Prune_CI_matrix Feb 24, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Roadmap Feb 24, 2026
@brownbaerchen brownbaerchen deleted the copilot/sub-pr-2139 branch February 24, 2026 14:50
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants