Skip to content

Update script path for auto updating pytorch#2308

Merged
mtar merged 8 commits into
mainfrom
bugs/2306-_Bug_failing_action_Get_latest_PyTorch_version_release_branch
May 27, 2026
Merged

Update script path for auto updating pytorch#2308
mtar merged 8 commits into
mainfrom
bugs/2306-_Bug_failing_action_Get_latest_PyTorch_version_release_branch

Conversation

@mtar

@mtar mtar commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • NEW unit tests: MPS tested (1 MPI process, 1 GPU)
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Updates the path of 'increment_path.py' after the workflow changes. Deprecation warning for code in the workflow itself has been fixed.

Issue/s resolved: #2306

Changes proposed:

  • update path in workflow action
  • handle deprecations warnings

Type of change

Bug fix

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

no

@github-project-automation github-project-automation Bot moved this to Todo in Roadmap May 21, 2026
@mtar mtar marked this pull request as draft May 21, 2026 08:20
@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.70%. Comparing base (86eb546) to head (396e5b9).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2308      +/-   ##
==========================================
- Coverage   91.71%   91.70%   -0.01%     
==========================================
  Files          87       87              
  Lines       14284    14291       +7     
==========================================
+ Hits        13100    13106       +6     
- Misses       1184     1185       +1     
Flag Coverage Δ
unit 91.70% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtar mtar marked this pull request as ready for review May 21, 2026 13:18
@mtar

mtar commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

One deprecation warning is left for an older github action that hasn't been updated for a while.

@mtar mtar changed the title Update script path for updating pytorch Update script path for auto updating pytorch May 21, 2026

@brownbaerchen brownbaerchen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorry that we didn't pay enough attention to merge these typos in #1884!

@github-project-automation github-project-automation Bot moved this from Todo to Merge queue in Roadmap May 21, 2026

@JuanPedroGHM JuanPedroGHM left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that, I need to get myself another github action/yaml checker 😓

@mtar mtar merged commit 24828cf into main May 27, 2026
13 checks passed
@mtar mtar deleted the bugs/2306-_Bug_failing_action_Get_latest_PyTorch_version_release_branch branch May 27, 2026 09:08
@github-project-automation github-project-automation Bot moved this from Merge queue to Done in Roadmap May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: failing action 'Get latest PyTorch version release branch'

3 participants