First small cleanup#2335
Merged
ClaudiaComito merged 2 commits intoJun 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a small cleanup in DNDarray indexing by removing / simplifying distr_mask_fast_path branches that are effectively unreachable, reducing conditional complexity in __process_key() without changing behavior.
Changes:
- Move the distributed-mask “early out” return to live directly under the condition that establishes the fast-path mask criteria.
- Remove an unreachable
if not distr_mask_fast_path: ... else: keep raw boolean maskbranch in the boolean-indexing handling. - Simplify a mask-like
op_typeassignment in an earlier return path wheredistr_mask_fast_pathcannot apply.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ClaudiaComito
merged commit eaa34eb
into
helmholtz-analytics:914_adv-indexing-outshape-outsplit
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny cleanup with some
distr_mask_fast_pathstuff. It doesn't get rid of it, just of a section that cannot be reached.