Better error message for unknown device#2343
Merged
brownbaerchen merged 3 commits intoJun 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make sanitize_device()/use_device() errors more informative by including the originally requested device identifier in the “unknown device” ValueError, and adds a regression test to assert that behavior.
Changes:
- Update the “unknown device”
ValueErrormessage inheat/core/devices.pyto include the requested device. - Add a new test asserting the requested device string appears in the error message.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/core/test_devices.py | Adds a regression test checking the unknown-device error message includes the requested device. |
| heat/core/devices.py | Updates the ValueError message raised for unknown device identifiers to include the requested device. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mtar
previously approved these changes
Jun 10, 2026
mtar
left a comment
mtar
left a comment
Collaborator
There was a problem hiding this comment.
One small suggestion to make the available options clearer.
Co-authored-by: Michael Tarnawa <18899420+mtar@users.noreply.github.com>
mtar
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the requested device in the error message when said device is not found.
It also includes a test for this. Note the handy
matchargument ofpytest.raisesthat makes such tests convenient.