fix: pack salience planner, config preflight, vector validation, 2 new proof scenarios - #21
Merged
Merged
Conversation
…or read-only validation Phase D — Pack Salience Planner: - New src/formatters/pack-planner.ts: planPackMemories() selects by salience - Mandatory: pinned, priority>0, blocking command_policy, high-severity fragile/failed/known_fix/agent_mistake - Optional sorted by retrieval score; omitted memories summarized without content - Wired into formatPackMarkdown() replacing line-by-line truncation Phase F — Preflight Enforce Config: - preflight --enforce now uses config.preflight.enforce_warn_exit_code and enforce_block_exit_code - Was hardcoded to 1/2 previously Phase G — Vector Read-Only Validation: - searchVectorIndexReadOnly() now validates projectId, provider name, and dimensions - Returns empty when mismatch detected Phase H — ProjectMind Scenarios 5-6: - architecture-decision: proves memory surfaces for DB-related task - supersession-visibility: proves old hidden, replacement quaranatinable - 6/6 scenarios pass in isolated temp workspaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements remaining ProjectMind hardening phases: pack salience planner, config-driven preflight enforcement, vector read-only validation, and 2 additional causal proof scenarios.
Changes
Pack Salience Planner (Phase D)
src/formatters/pack-planner.ts:planPackMemories()selects by salience before renderingformatPackMarkdown()replacing line-by-line truncationPreflight Config Exit Codes (Phase F)
preflight --enforcenow usesconfig.preflight.enforce_warn_exit_codeandenforce_block_exit_codeVector Read-Only Validation (Phase G)
searchVectorIndexReadOnly()validates projectId, provider name, and dimensionsProjectMind Scenarios 5-6 (Phase H)
Verification