Skip to content

chore(e5c9): delete the hand-written guardduty, securityhub and inspector2 - #528

Merged
hemzaz merged 1 commit into
masterfrom
feat/e5c9-delete-handwritten-security
Nov 16, 2026
Merged

hemzaz merged 1 commit into
masterfrom
feat/e5c9-delete-handwritten-security

Conversation

@hemzaz

@hemzaz hemzaz commented Nov 16, 2026

Copy link
Copy Markdown
Owner

E5c9 of the E5c plan. Since E5c8 (#527) no stack has an instance of the hand-written components: the vendored Cloud Posse aws-guardduty, aws-security-hub and aws-inspector2 (delegated administrator + org-settings) own the services. Deletion PR, size-exempt per the plan.

  • Deleted components/terraform/{guardduty,securityhub,inspector2} (tests and the inline CKV2_AWS_3 skip included) and stacks/catalog/{guardduty,securityhub,inspector2}.
  • CODEOWNERS: the three catalog entries name the vendored catalogs.
  • deploy-full-stack: the old names leave the security layer's plan and deploy queries (both copies).
  • check-first-deploy-inputs: the old names leave MAP_CONSUMERS; tests use aws-guardduty.
  • plan_sweep_hcl: account_ids (only the deleted aws_inspector2_enabler) leaves LIST_SCALAR_ATTRS.
  • README 60 root modules (44 hand-written); CLAUDE.md 38 of the 44 validate tags.Environment; aws-security-hub catalog comments no longer point at deleted files.

Test plan

  • bash scripts/stack-snapshot.sh compare IDENTICAL (28 stacks)
  • git grep "guardduty/main|securityhub/main|inspector2/main": only the test_harden.py retired-instance guard and the vendored aws-guardduty/main.tf
  • script unit tests (1035 OK), plan_sweep_varfile.py --self-test
  • atmos workflow lint -f lint
  • atmos workflow validate-all -f validate-enhanced
  • CI green (security-scan: no stale allowlist entry), then promote

…ctor2

E5c9 of the E5c plan. Since E5c8 (#527) no stack has an instance of the
hand-written components: the vendored Cloud Posse aws-guardduty,
aws-security-hub and aws-inspector2 (delegated administrator + org-settings)
own the services. Deletion PR, size-exempt per the plan.

- Deleted components/terraform/{guardduty,securityhub,inspector2} (tests and
  the inline CKV2_AWS_3 skip included) and stacks/catalog/{guardduty,securityhub,inspector2}.
- CODEOWNERS: the three catalog entries name the vendored catalogs.
- deploy-full-stack: the old names leave the security layer's plan and deploy
  queries (both copies).
- check-first-deploy-inputs: the old names leave MAP_CONSUMERS; tests use
  aws-guardduty.
- plan_sweep_hcl: account_ids (only the deleted aws_inspector2_enabler) leaves
  LIST_SCALAR_ATTRS.
- README 60 root modules (44 hand-written); CLAUDE.md 38 of the 44 validate
  tags.Environment; aws-security-hub catalog comments no longer point at
  deleted files.

Resolved stacks are byte-identical (stack-snapshot IDENTICAL, 28 stacks).
@hemzaz
hemzaz marked this pull request as ready for review November 16, 2026 22:57
@hemzaz
hemzaz merged commit 7330e27 into master Nov 16, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant