Repository navigation
chore(e5c9): delete the hand-written guardduty, securityhub and inspector2 - #528
Merged
Merged
Conversation
…ctor2 E5c9 of the E5c plan. Since E5c8 (#527) no stack has an instance of the hand-written components: the vendored Cloud Posse aws-guardduty, aws-security-hub and aws-inspector2 (delegated administrator + org-settings) own the services. Deletion PR, size-exempt per the plan. - Deleted components/terraform/{guardduty,securityhub,inspector2} (tests and the inline CKV2_AWS_3 skip included) and stacks/catalog/{guardduty,securityhub,inspector2}. - CODEOWNERS: the three catalog entries name the vendored catalogs. - deploy-full-stack: the old names leave the security layer's plan and deploy queries (both copies). - check-first-deploy-inputs: the old names leave MAP_CONSUMERS; tests use aws-guardduty. - plan_sweep_hcl: account_ids (only the deleted aws_inspector2_enabler) leaves LIST_SCALAR_ATTRS. - README 60 root modules (44 hand-written); CLAUDE.md 38 of the 44 validate tags.Environment; aws-security-hub catalog comments no longer point at deleted files. Resolved stacks are byte-identical (stack-snapshot IDENTICAL, 28 stacks).
hemzaz
marked this pull request as ready for review
November 16, 2026 22:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E5c9 of the E5c plan. Since E5c8 (#527) no stack has an instance of the hand-written components: the vendored Cloud Posse
aws-guardduty,aws-security-hubandaws-inspector2(delegated administrator + org-settings) own the services. Deletion PR, size-exempt per the plan.components/terraform/{guardduty,securityhub,inspector2}(tests and the inlineCKV2_AWS_3skip included) andstacks/catalog/{guardduty,securityhub,inspector2}.deploy-full-stack: the old names leave the security layer's plan and deploy queries (both copies).check-first-deploy-inputs: the old names leaveMAP_CONSUMERS; tests useaws-guardduty.plan_sweep_hcl:account_ids(only the deletedaws_inspector2_enabler) leavesLIST_SCALAR_ATTRS.tags.Environment;aws-security-hubcatalog comments no longer point at deleted files.Test plan
bash scripts/stack-snapshot.sh compareIDENTICAL (28 stacks)git grep "guardduty/main|securityhub/main|inspector2/main": only thetest_harden.pyretired-instance guard and the vendoredaws-guardduty/main.tfplan_sweep_varfile.py --self-testatmos workflow lint -f lintatmos workflow validate-all -f validate-enhanced